Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] allow unused parameters in metric when using make_forecasting_scorer #4833

Merged
merged 5 commits into from Jul 13, 2023
Merged

[BUG] allow unused parameters in metric when using make_forecasting_scorer #4833

merged 5 commits into from Jul 13, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jul 5, 2023

Fixes #4827 by ignoring parameters that are not present in the default params of a metric.

@fkiraly fkiraly added bugfix Fixes a known bug or removes unintended behavior module:metrics&benchmarking metrics and benchmarking modules labels Jul 5, 2023
@fkiraly fkiraly merged commit 22b8854 into main Jul 13, 2023
24 checks passed
@fkiraly fkiraly deleted the make-scorer-params-intersection branch July 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achieveordie achieveordie achieveordie approved these changes

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:metrics&benchmarking metrics and benchmarking modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] make_forecasting_scorer and functools.partial don't mix.
2 participants
@fkiraly @achieveordie