[BUG] clarify tuning estimators' docstrings and error messages in case of refit=False
#4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
bug
fkiraly
changed the title
ForecastingGridSearchCV.predict failure on refit=Falserefit=False
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
fkiraly
changed the title
refit=Falserefit=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4929
As discussed there, the
refit=Falseparameter was incorrectly described in docstrings, and error messages that were raised were not informative.This PR updates the docstring with a clear description of how
refit=Falseis intended to be used, and adds an informative error message.