Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] rewrite test_probabilistic_metrics using proper pytest fixtures #4946

Merged
merged 10 commits into from Jul 24, 2023
Merged

[ENH] rewrite test_probabilistic_metrics using proper pytest fixtures #4946

merged 10 commits into from Jul 24, 2023

Commits on Jul 22, 2023

  1. intermediate result

    @julikraus
    julikraus committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    ac8d969 View commit details
    Browse the repository at this point in the history

  2. intermediate status

    @julikraus
    julikraus committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    d35c162 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. refactor: intermediate: refactor tests. Split interval and quantiles … 

    …tests

reason: If all test combinations are run in the same function, the computation takes too long, because there are more than 150 combinations
    @julikraus
    julikraus committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3255600 View commit details
    Browse the repository at this point in the history

  2. refactor: split test_output into two functions, one for quantile pr… 

    …edictions, and one for interval predictions

Reason: The original functions had 96 parameter combinations and hence 96 tests. Also, quantiles and intervals have their dedicated metrics, so cross-combinations are unnecessary. The separation speeds up the test suite considerably.
    @julikraus
    julikraus committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    589256d View commit details
    Browse the repository at this point in the history

  3. docs: add julia-kraus to contributors

    @julikraus
    julikraus committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    31b2c31 View commit details
    Browse the repository at this point in the history

  4. style: run black and flake

    @julikraus
    julikraus committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    59be591 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update test_probabilistic_metrics.py

    @fkiraly
    fkiraly committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c174fd2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pr/4946

    @fkiraly
    fkiraly committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    694e062 View commit details
    Browse the repository at this point in the history

  3. test: 

    run all_metrics for test of both interval and quantile data
    @julikraus
    julikraus committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    852753e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pytest_issue' of github.com:julia-kraus/sktime into pyt… 

    …est_issue
    @julikraus
    julikraus committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9958cd5 View commit details
    Browse the repository at this point in the history