[ENH] speed up BaseTransformer checks and conversion boilerplate
#5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
implementing framework
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
This was referenced Aug 9, 2023
fkiraly
added a commit
that referenced
this pull request
Aug 14, 2023
This PR speeds up the parameter fitter base class boilerplate by avoiding to carry out mtype checks twice. This is achieved by replacing one instance of `convert_to` (which checks the mtype, redundant to `check_is_mtype`), by an equivalent instance of `convert`, using the mtype output of `check_is_mtype`. Related: #5056 #5036 Depends on #5036 due to the changes to `convert` being common to both speed-ups.
fkiraly
added a commit
that referenced
this pull request
Aug 19, 2023
This PR speeds up the checks and conversions boilerplate in `BaseSplitter`. * avoids unnecessary checks to detect mtype, by replacing `convert_to` by a more specific `convert` * prevents unnecessary metadata computation in `check_is_scitype` by adjusting the requested metadata argument to none To effect this, adds an argument and logic to `convert` and `convert_to` that allows to return the mtype of the object that was returned - this is not immediate from the arguments, as the `to_type` can be an allow-list. Related, and depends on (for changes to `convert`): #5036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
BaseTransformerchecks and conversion boilerplate:convert_tocalls by more specificconvertcalls that ensure we do not repeat mtype checksconvertandconvert_to, moving logic that determines the target mtype into a separate function, and allowingconvertto havelistasto_typeconvert_to_scitypeto return the mtype of the converted-to output. This is passed as an input toconvertin theBaseTransformerboilerplate to avoid checks to obtain this information.