Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] allow YfromX to take missing data #5062

Merged
merged 1 commit into from Aug 10, 2023
Merged

[ENH] allow YfromX to take missing data #5062

merged 1 commit into from Aug 10, 2023

Conversation

eenticott-shell
Copy link
Collaborator

Reference Issues/PRs

Fixes #5061

What does this implement/fix? Explain your changes.

Changes tag on YfromX to allow missing data in X

fkiraly
fkiraly approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - yes, it should not throw out missing data.

@fkiraly fkiraly added module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting bugfix Fixes a known bug or removes unintended behavior labels Aug 9, 2023
@eenticott-shell eenticott-shell marked this pull request as ready for review August 9, 2023 12:13
@fkiraly fkiraly changed the title Allow YfromX to take missing data [ENH] allow YfromX to take missing data Aug 9, 2023
@fkiraly fkiraly merged commit 570daa2 into sktime:main Aug 10, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Allow YfromX to handle missing data
2 participants
@eenticott-shell @fkiraly