[ENH] conditional execution of test_distance and test_distance_params
#5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:distances&kernels
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
fkiraly
changed the title
test_distance_paramstest_distance and test_distance_params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up tests by making
test_distanceandtest_distance_paramsconditionally execute if and only if the respective distance function's module has changed with respect tomain.To accomplish this, the
run_tests_for_classutility is extended slightly to also allow passing of functions. The name is not changed to avoid conflicts between ongoing PR.