Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test_afc.py #511

Closed
wants to merge 2 commits into from
Closed

Added test_afc.py #511

wants to merge 2 commits into from

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Nov 30, 2020

Reference Issues/PRs

Fixes #483

What does this implement/fix? Explain your changes.

Added unit tests for the transformer

Does your contribution introduce a new dependency? If yes, which one?

No

PR checklist

  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • I've added the transformers series to the file.
  • I've updated the existing file.

@mloning
Copy link
Contributor

mloning commented Nov 30, 2020

@Afzal-Ind the unit tests looks great - exactly what I had in mind, good work! Could you add it to the other PR #509 so that it's all in one place?

@afzal442
Copy link
Contributor Author

afzal442 commented Dec 1, 2020

Could you add it to the other PR #509 so that it's all in one place?

Thanks a lot again for your guidance. I would add it definitely.

@mloning
Copy link
Contributor

mloning commented Dec 7, 2020

Closed in favour of #509

@mloning mloning closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement series-to-series transformers
2 participants