Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] iisignature backend option for SignatureTransformer #5398

Merged
merged 23 commits into from Nov 4, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d759be4
Replaced the backend in _compute with the iisignature so could handle…
sz85512678 Sep 22, 2023
1a6ea3b
Fixed a bug to allow no augmentation
sz85512678 Sep 22, 2023
17ba0c7
Add to contributor list.
sz85512678 Oct 11, 2023
120fff9
responde to requested change, allow the user to specify additional ii…
sz85512678 Oct 13, 2023
191c860
Improved docstring, error message; Added upper bound on version of ii…
sz85512678 Oct 16, 2023
8fd0448
Merge branch 'main' into pr/5398
fkiraly Oct 22, 2023
9c53bec
[AUTOMATED] update CONTRIBUTORS.md
fkiraly Oct 22, 2023
7988aac
fix merge accident
fkiraly Oct 22, 2023
c778cee
Merge branch 'main' of https://github.com/sz85512678/sktime into pr/5398
fkiraly Oct 22, 2023
768d3ee
[AUTOMATED] update CONTRIBUTORS.md
fkiraly Oct 22, 2023
af35f11
Merge branch 'main' into pr/5398
fkiraly Nov 1, 2023
e5b411b
Merge branch 'main' of https://github.com/sz85512678/sktime into pr/5398
fkiraly Nov 1, 2023
b3a8369
linting
fkiraly Nov 4, 2023
f7d96bc
Merge branch 'main' into pr/5398
fkiraly Nov 4, 2023
5cca6ca
[AUTOMATED] update CONTRIBUTORS.md
fkiraly Nov 4, 2023
5588ea6
Update _compute.py
fkiraly Nov 4, 2023
61b06a9
Merge branch 'main' of https://github.com/sz85512678/sktime into pr/5398
fkiraly Nov 4, 2023
2ad69b5
docstrs
fkiraly Nov 4, 2023
203da6e
Update _signature_method.py
fkiraly Nov 4, 2023
00d35b0
remove iisignature as softdep
fkiraly Nov 4, 2023
32a6532
Update _signature_method.py
fkiraly Nov 4, 2023
31f1dbd
Update _signature_method.py
fkiraly Nov 4, 2023
8104135
Update _signature_method.py
fkiraly Nov 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
Expand Up @@ -2365,6 +2365,15 @@
"bug",
"code"
]
},
{
"login": "sz85512678",
"name": "Zhen Shao",
"avatar_url": "https://avatars.githubusercontent.com/sz85512678",
"profile": "https://github.com/sz85512678",
"contributions": [
"code"
]
}
]
}
10 changes: 5 additions & 5 deletions sktime/transformations/panel/signature_based/_augmentations.py
Expand Up @@ -43,11 +43,11 @@ def _make_augmentation_pipeline(augmentation_list):
if augmentation_list is not None:
if isinstance(augmentation_list, str):
augmentation_list = (augmentation_list,)
assert all(
[x in list(AUGMENTATIONS.keys()) for x in augmentation_list]
), "augmentation_list must only contain string elements from {}. Given: {}.".format(
list(AUGMENTATIONS.keys()), augmentation_list
)
assert all(
[x in list(AUGMENTATIONS.keys()) for x in augmentation_list]
), "augmentation_list must only contain string elements from {}. Given: {}.".format(
list(AUGMENTATIONS.keys()), augmentation_list
)

# Setup pipeline
if augmentation_list is not None:
Expand Down
1 change: 1 addition & 0 deletions sktime/transformations/panel/signature_based/_compute.py
Expand Up @@ -61,6 +61,7 @@ def __init__(

def _transform(self, X, y=None):
import esig
esig.set_backend("iisignature")

depth = self.sig_depth
data = np.swapaxes(X, 1, 2)
Expand Down