Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] xfail remote data loaders to silence sporadic failures #5461

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 20, 2023

This PR adds an xfail to the UCR loader and the Monash loader - both retrieving benchmark data from the internet - in order to silence the sporadic failures described in bug reports #5460 and #5462.

Only a temporary measure, possibly also rectified by the CI refactor with a separate data testing element.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:datasets&loaders data sets and data loaders labels Oct 20, 2023
@fkiraly fkiraly changed the title [MNT] xfail UCR loader to silence sporadic failures [MNT] xfail remote data loaders to silence sporadic failures Oct 20, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 20, 2023

failure on main - merging

@fkiraly fkiraly merged commit 5e8d230 into main Oct 20, 2023
28 checks passed
@fkiraly fkiraly deleted the xfail-uea branch October 20, 2023 13:49
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 22, 2023
* origin/main:
  [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395)
  [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459)
  [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304)
  [MNT] new CI workflow to test extras (sktime#5375)
  [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461)
  [BUG] [MNT] removed two recently added hooks (sktime#5453)
  [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 22, 2023
…sting

* origin/main:
  [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395)
  [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459)
  [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304)
  [MNT] new CI workflow to test extras (sktime#5375)
  [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461)
  [BUG] [MNT] removed two recently added hooks (sktime#5453)
  [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 22, 2023
…heck

* origin/main:
  [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395)
  [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459)
  [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304)
  [MNT] new CI workflow to test extras (sktime#5375)
  [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461)
  [BUG] [MNT] removed two recently added hooks (sktime#5453)
  [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 22, 2023
* origin/main:
  [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395)
  [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459)
  [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304)
  [MNT] new CI workflow to test extras (sktime#5375)
  [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461)
  [BUG] [MNT] removed two recently added hooks (sktime#5453)
  [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution module:datasets&loaders data sets and data loaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant