-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] xfail remote data loaders to silence sporadic failures #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
maintenance
Continuous integration, unit testing & package distribution
module:datasets&loaders
data sets and data loaders
labels
Oct 20, 2023
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
October 20, 2023 12:08
fkiraly
changed the title
[MNT] xfail UCR loader to silence sporadic failures
[MNT] xfail remote data loaders to silence sporadic failures
Oct 20, 2023
failure on main - merging |
yarnabrina
added a commit
to yarnabrina/sktime-fork
that referenced
this pull request
Oct 22, 2023
* origin/main: [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395) [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459) [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304) [MNT] new CI workflow to test extras (sktime#5375) [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461) [BUG] [MNT] removed two recently added hooks (sktime#5453) [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina
added a commit
to yarnabrina/sktime-fork
that referenced
this pull request
Oct 22, 2023
…sting * origin/main: [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395) [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459) [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304) [MNT] new CI workflow to test extras (sktime#5375) [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461) [BUG] [MNT] removed two recently added hooks (sktime#5453) [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina
added a commit
to yarnabrina/sktime-fork
that referenced
this pull request
Oct 22, 2023
…heck * origin/main: [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395) [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459) [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304) [MNT] new CI workflow to test extras (sktime#5375) [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461) [BUG] [MNT] removed two recently added hooks (sktime#5453) [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina
added a commit
to yarnabrina/sktime-fork
that referenced
this pull request
Oct 22, 2023
* origin/main: [BUG] Fix pandas `FutureWarning` for silent upcasting (sktime#5395) [BUG] CLASP logic: remove indexes from exclusion zone that are out of range (sktime#5459) [MNT] Split CI jobs per components with specific soft-dependencies (sktime#5304) [MNT] new CI workflow to test extras (sktime#5375) [MNT] xfail remote data loaders to silence sporadic failures (sktime#5461) [BUG] [MNT] removed two recently added hooks (sktime#5453) [MNT] bound `pycatch22<0.4.4` due to breaking change in patch version (sktime#5434)
yarnabrina
added a commit
to yarnabrina/sktime-fork
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Continuous integration, unit testing & package distribution
module:datasets&loaders
data sets and data loaders
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an xfail to the UCR loader and the Monash loader - both retrieving benchmark data from the internet - in order to silence the sporadic failures described in bug reports #5460 and #5462.
Only a temporary measure, possibly also rectified by the CI refactor with a separate data testing element.