Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] suggested shorter names for CI workflow elements #5470

Merged
merged 2 commits into from Nov 3, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 21, 2023

For review by @yarnabrina - suggested shorter or clearer names for CI workflow elements introduced in recent PRs.

Main changes:

  • changing term "component" to "module" to avoid confusion with estimator components
  • making names shorter to facilitate easy reading and visibility in GitHub web interface

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution enhancement Adding new functionality labels Oct 21, 2023
yarnabrina
yarnabrina previously approved these changes Oct 22, 2023
Copy link
Collaborator

@yarnabrina yarnabrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no problem with any of these text changes. Looks fine.

However, I'll request to merge it after #5427, otherwise may cause some unnecessary conflicts.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 22, 2023

However, I'll request to merge it after #5427,

Of course.

@fkiraly fkiraly merged commit e14da00 into main Nov 3, 2023
32 checks passed
@fkiraly fkiraly deleted the shorter-CI-names branch November 3, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants