New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] estimator serialization: user choice of serialization_format
, support for cloudpickle
#5486
Conversation
The errors seem unrelated, rerunning it to confirm. |
The current CI failure is due to a known issue #5026. |
@@ -6,6 +6,12 @@ | |||
from sktime.tests.test_switch import run_test_for_class | |||
|
|||
|
|||
# A reference to this issue is also present inside sktime/tests/_config.py, | |||
# and needs to be removed from `EXCLUDED_TESTS` upon resolution. | |||
@pytest.mark.skip( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is sporadic, we should not skip it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the general consensus on dealing with such sporadic errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Small blocking things:
- I would spell the available formats out in the docstring directly. There are just two options.
- I would split this PR up in two, one with the serialization format, one for
mlflow
extension.
Non-blocking, out of scope for this PR but perhaps worth a look: @benjaminbluhm has continued to develop the mlflow
plugin as part of mlflavours
. I am not sure of its status, but perhaps you want a quick look whether adding this in one of the two or both places makes sense, whether we want to backport sth, or outsource sth to mlflavours
.
If @benjaminbluhm doesn't mind, I'll open a similar PR there as well. |
serialization_format
and add support for DL estimators with mlflow
serialization_format
I'll make a follow-up PR for mlflow changes after this has been merged. |
Two errors are related to #5488 and one error is from a tacky HTTPS connection, all unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
serialization_format
serialization_format
, support for cloudpickle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me now!
Reference Issues/PRs
In reference to #5324
What does this implement/fix? Explain your changes.
serialization_format
(currentlypickle
andcloudpickle
are supported) for all estimators.sktime_mlflow
to also be able to save DL estimators.Does your contribution introduce a new dependency? If yes, which one?
None
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Yes, I've added tests for all the added functionalities, I'm open to suggestions for adding more tests.
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.