[BUG] in ClaSPSegmentation, deal with k when it is too large for np.argpartition

[Alex-JG3]

Reference Issues/PRs

Closes #5476.

What does this implement/fix? Explain your changes.

Sometimes the ClaSPSegmentation algorithm raises a value error in the _compute_distances_iterative method. This happens when _compute_distances_iterative attempts to use np.argpartition with a kth value which is larger than the length of the input array.

This PR checks if k is larger than the length of dist and if it is, it sets k to be the length of dist minus 1.

Does your contribution introduce a new dependency? If yes, which one?

No.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions

• I've added myself to the list of contributors with any new badges I've earned :-)
  How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
  See here for full badge reference
• Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
  See here for further details on the algorithm maintainer role.
• The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

[fkiraly]

Makes sense.

The way I would solve it is _k = min(k, len(dist)-1) and then use _k rather than if/else, but either is fine ofc.

[Alex-JG3]

The way I would solve it is _k = min(k, len(dist)-1) and then use _k rather than if/else, but either is fine ofc.

That is a much simpler solutions, thanks for pointing that out. I have made the change in afde81e

[fkiraly]

Well, still fine 😄