New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] support for probabilistic regressors (skpro
) in make_reduction
, direct reduction
#5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:forecasting
forecasting module: forecasting, incl probabilistic and hierarchical forecasting
enhancement
Adding new functionality
labels
Nov 6, 2023
fkiraly
changed the title
[ENH] support for probabilistic regressors (
[ENH] support for probabilistic regressors (Jan 9, 2024
skpro
) in make_reduction
skpro
) in make_reduction
, direct reduction
benHeid
reviewed
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Happy to approve the PR, after the one question I have is answered. I would think, that using pre-allocated arrays might improve the performance. However, I am also aware that they are very confusing...
benHeid
previously approved these changes
Jan 13, 2024
This was referenced Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Adding new functionality
module:forecasting
forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to extend
make_reduction
classes to support regressors with probabilistic prediction modes, with theskpro
interface.This would be achieved exactly as currently in
YfromX
which already does support probabilistic regressors, but unfortunately the inner structure ofmake_reduction
is much more nested and organically grown.The idea is to switch over
predict
andpredict_interval
internally, and leave the rest as-is.Hopefully, this will also not interact with the fixes to the reducers that @benHeid is currently working on.
Depends on #5539, #5725, #5726, which should be merged first.
Also fixes an unreported bug where the reducers could fail in a case where not all index levels were named, as said names were used as reference (in
_cut_df
). This has been remedied by using integer references.