Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] support for probabilistic regressors (skpro) in make_reduction, direct reduction #5536

Merged
merged 64 commits into from Jan 14, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Nov 6, 2023

The aim of this PR is to extend make_reduction classes to support regressors with probabilistic prediction modes, with the skpro interface.

This would be achieved exactly as currently in YfromX which already does support probabilistic regressors, but unfortunately the inner structure of make_reduction is much more nested and organically grown.

The idea is to switch over predict and predict_interval internally, and leave the rest as-is.

Hopefully, this will also not interact with the fixes to the reducers that @benHeid is currently working on.

Depends on #5539, #5725, #5726, which should be merged first.

Also fixes an unreported bug where the reducers could fail in a case where not all index levels were named, as said names were used as reference (in _cut_df). This has been remedied by using integer references.

@fkiraly fkiraly added module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting enhancement Adding new functionality labels Nov 6, 2023
@fkiraly fkiraly changed the title [ENH] support for probabilistic regressors (skpro) in make_reduction [ENH] support for probabilistic regressors (skpro) in make_reduction, direct reduction Jan 9, 2024
Copy link
Contributor

@benHeid benHeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Happy to approve the PR, after the one question I have is answered. I would think, that using pre-allocated arrays might improve the performance. However, I am also aware that they are very confusing...

sktime/forecasting/compose/_reduce.py Show resolved Hide resolved
benHeid
benHeid previously approved these changes Jan 13, 2024
@fkiraly fkiraly merged commit 65837eb into main Jan 14, 2024
55 checks passed
@fkiraly fkiraly deleted the reduce-proba branch January 14, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants