Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] [Dependabot](deps-dev): Update dask requirement from <2023.7.1 to <2023.11.1 #5552

Merged
merged 29 commits into from Nov 26, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Updates the requirements on dask to permit the latest version.

PR #5560 must be merged first to ensure compatibility of data containers with deep_equals.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [dask](https://github.com/dask/dask) to permit the latest version.
- [Changelog](https://github.com/dask/dask/blob/main/docs/release-procedure.md)
- [Commits](dask/dask@0.2.0...2023.11.0)

---
updated-dependencies:
- dependency-name: dask
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the maintenance Continuous integration, unit testing & package distribution label Nov 13, 2023
fkiraly added a commit that referenced this pull request Nov 24, 2023
…x`, relaxation of `MultiIndex` equality check (#5560)

This PR improves error messaging in `deep_equals` and makes checks on
`pandas` based indices stricter.

Changes:

* `dtypes` of `pd.DataFrame`-s are now checked explicitly
* providing a clearer return on `pd.DataFrame` `dtypes` no being equal
* `pd.Index` `dtypes` are now checked explicitly
* index equality check is slightly relaxed. `DataFrame.equals` may
consider `MultiIndex` as unequal due to irrelevant typing in some
`python` versions, so instead we now explicitly check equality in names,
values

This should help diagnose the `dask` inconsistency in
`VectorizedDF.reconstruct` return, I suspect it is the `dtype`.
Example of test failure (only on certain python versions) here:
#5552
(update: this was due to `MultiIndex` type ambiguity, with the
relaxation of the `deep_equals` check this should be fine now)

Depends on #5561 which fixes inconsistencies uncovered through
the above.
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compatibility issues should be resolved.

@fkiraly fkiraly merged commit 4be5c66 into main Nov 26, 2023
40 checks passed
@fkiraly fkiraly deleted the dependabot/pip/dask-lt-2023.11.1 branch November 26, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant