New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] [Dependabot](deps-dev): Update dask requirement from <2023.7.1 to <2023.11.1 #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [dask](https://github.com/dask/dask) to permit the latest version. - [Changelog](https://github.com/dask/dask/blob/main/docs/release-procedure.md) - [Commits](dask/dask@0.2.0...2023.11.0) --- updated-dependencies: - dependency-name: dask dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
achieveordie,
benHeid,
fkiraly and
yarnabrina
as code owners
November 13, 2023 21:03
dependabot
bot
added
the
maintenance
Continuous integration, unit testing & package distribution
label
Nov 13, 2023
fkiraly
added a commit
that referenced
this pull request
Nov 24, 2023
…x`, relaxation of `MultiIndex` equality check (#5560) This PR improves error messaging in `deep_equals` and makes checks on `pandas` based indices stricter. Changes: * `dtypes` of `pd.DataFrame`-s are now checked explicitly * providing a clearer return on `pd.DataFrame` `dtypes` no being equal * `pd.Index` `dtypes` are now checked explicitly * index equality check is slightly relaxed. `DataFrame.equals` may consider `MultiIndex` as unequal due to irrelevant typing in some `python` versions, so instead we now explicitly check equality in names, values This should help diagnose the `dask` inconsistency in `VectorizedDF.reconstruct` return, I suspect it is the `dtype`. Example of test failure (only on certain python versions) here: #5552 (update: this was due to `MultiIndex` type ambiguity, with the relaxation of the `deep_equals` check this should be fine now) Depends on #5561 which fixes inconsistencies uncovered through the above.
fkiraly
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compatibility issues should be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on dask to permit the latest version.
PR #5560 must be merged first to ensure compatibility of data containers with
deep_equals
.Commits
b2f11d0
bump version to 2023.11.0972352a
Add warning forpyarrow<14.0.1
usage (#10622)d58bc9b
Fix sporadic failure oftest_dataframe::test_quantile
(#10625)4b93eae
Bump minimumclick
to>=8.1
(#10623)c71fc74
Refactor test_quantile (#10620)0e461f1
AvoidPerformanceWarning
for fragmented DataFrame (#10621)91098a6
Generalize computation ofNEW_*_VER
in GPU CI updating workflow (#10610)f545749
Switch to newer GPU CI images (#10608)1a182fa
Use the inferred filesystem/region by default whenfilesystem='arrow'
(#1...9c2da1b
Remove double slash infsspec
tests (#10605)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)