[BUG] fix scitype coerce_to_list parameter, add test coverage
#5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
bugfix
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
fkiraly
added a commit
that referenced
this pull request
Dec 22, 2023
…to central location (#5574) This PR adds a test class register in the main `tests` folder, and refactors `check_estimator` test gathering to that central location. This is in anticipation of: * test gathering potentially across `python` packages, e.g., polymorphic pipelines with components across packages * unified `check_estimator` interfaces across packages * simplifying extension pattern when adding more scitypes * logic for switching on tests for all affected estimators when test classes are changed Depends on #5578 due to a bug in the `scitype` utility that needed to be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unreported bug where
registry.scitypewould return strings even ifcoerce_to_list=True.To ensure future coverage, a test is also added.