Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] reduce private coupling of IndividualBOSS classifier and BaseClassifier #5654

Merged
merged 6 commits into from Jan 14, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Dec 22, 2023

This PR removes an instance of problematic private coupling of IndividualBOSS classifier to the boilerplate layer of BaseClassifier, which could make IndividualBOSS and dependents break in boilerplate refactor such as #5408.

The _shorten_bags logic internally made a "fitted clone" of self, with explicit copying of attributes, that assumed specifics of the private structure of BaseClassifier such as "names of all private attributes" that were hard-coded in IndividualBOSS.

This coupling has been removed to the largest extent by instead using deepcopy and changing only the attributes that need to change.

@fkiraly fkiraly added module:classification classification module: time series classification enhancement Adding new functionality labels Dec 22, 2023
@fkiraly fkiraly merged commit 8abb941 into main Jan 14, 2024
56 checks passed
@fkiraly fkiraly deleted the boss-shorten-bags branch January 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant