Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix extract_path arg in sktime.datasets.load_UCR_UEA_dataset #5744

Merged
merged 2 commits into from Jan 16, 2024
Merged

[BUG] fix extract_path arg in sktime.datasets.load_UCR_UEA_dataset #5744

merged 2 commits into from Jan 16, 2024

Conversation

steenrotsman
Copy link
Contributor

@steenrotsman steenrotsman commented Jan 15, 2024 •
edited by fkiraly

Reference Issues/PRs

Fixes #5591.

What does this implement/fix? Explain your changes.

Ensures check_path is set as suggested by @fkiraly.

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

@fkiraly fkiraly changed the title [BUG] sktime.datasets.load_UCR_UEA_dataset [BUG] fix extract_path arg in sktime.datasets.load_UCR_UEA_dataset Jan 15, 2024
@fkiraly fkiraly added bugfix Fixes a known bug or removes unintended behavior module:datasets&loaders data sets and data loaders labels Jan 15, 2024
fkiraly
fkiraly previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, forgot about that issue!

I was also thinking on how to best test this, though it seems unpleasant as one would have to work on the CI virtual machines.

@steenrotsman
Copy link
Contributor Author

The - crude - way in which I tested locally was by seeing if load_UCR_UEA_dataset(name="ArrowHead", extract_path="data/xxx") raised a FileNotFoundError instead of an UnboundLocalError.

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 15, 2024

well, we could add that - that is better than nothing. except FileNotFoundError as e and otherwise raise.

@fkiraly fkiraly merged commit 9a639a1 into sktime:main Jan 16, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior module:datasets&loaders data sets and data loaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] using custom extract_path does not work in sktime.datasets.load_UCR_UEA_dataset
2 participants
@steenrotsman @fkiraly