New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add disp
parameter to sarimax to control output verbosity
#5770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Left some non-blocking comments above.
Other non-blocking comments, this relates to multiple issues where fit
parameters of the interfaced method are not exposed via the sktime
constructor.
statsmodels
- #4377
pmdarima
- #2344
As you have looked into the statsmodels
estimators, do you perchance know whether now all the fit_params
are exposed in all estimators, so we can close the related issue #4377?
The same problem exists for other packages, in case you have some awareness there.
Not all estimators expose all |
Well, if you would be kind enough to deal with it in one stroke, that would be very much appreciated. No pressure though. |
I'm working now and another PR for |
Reference Issues/PRs
Closes #5712
What does this implement/fix? Explain your changes.
Added the
disp
parameter to the constructor ofSARIMAX
to control the verbosity of the printed convergence messages. It follows the same naming convention as other models like DynamicFactor, AutoETS, VARMAX.What should a reviewer concentrate their feedback on?
Do I need a changelog for this?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
See here for further details on the algorithm maintainer role.
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.