Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] handles AttributeError in show_versions() when dependency lacks __version__ #5793

Merged
merged 3 commits into from Jan 20, 2024

Conversation

yarnabrina
Copy link
Collaborator

Closes #5788

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like it would work.

I would appreciate an explanation, can you confirm: the idea is that get_version will now never result in an exception, therefore we move it out of the try/except statement.

Further, it would be appreciated if you could make the same change in scikit-base, ultimately it makes sense to refactor the logic to be located there.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:base-framework BaseObject, registry, base framework bugfix Fixes a known bug or removes unintended behavior labels Jan 20, 2024
@yarnabrina
Copy link
Collaborator Author

the idea is that get_version will now never result in an exception, therefore we move it out of the try/except statement.

Right, confirmed.

@fkiraly fkiraly merged commit e0e50a4 into sktime:main Jan 20, 2024
54 checks passed
@yarnabrina yarnabrina deleted the bug-sktime-5788 branch January 21, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior maintenance Continuous integration, unit testing & package distribution module:base-framework BaseObject, registry, base framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] show_versions is failing with AttributeError
2 participants