Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] pyts adapter and interface to pyts ROCKET #5851

Merged
merged 11 commits into from Feb 15, 2024
Merged

[ENH] pyts adapter and interface to pyts ROCKET #5851

merged 11 commits into from Feb 15, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jan 27, 2024 •
edited

Towards #5850, this PR adds a general interface towards pyts, and an interface to pyts ROCKET (as implicitly suggested in #5849).

pyts uses the numpyflat mtype internally, so the tslearn adapter should mostly translate (only diff is mtype, tslearn uses numpy3D). Mid-term, one could think about refactoring both adapters to incrase DRY-ness, if it should work for pyts.

pyts is added to the all_extras dependency set. Notably, pyts depends on numba, which means 3.11 or lower.

For now, I have avoided adding it to the other dependency sets, as it might cause restrictions.

@fkiraly fkiraly added interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing labels Jan 27, 2024
@fkiraly fkiraly mentioned this pull request Jan 27, 2024
Open
@fkiraly fkiraly mentioned this pull request Feb 13, 2024
Merged
@fkiraly fkiraly merged commit 7bde5e4 into main Feb 15, 2024
228 checks passed
@fkiraly fkiraly deleted the pyts-rocket branch February 15, 2024 21:43
fkiraly added a commit that referenced this pull request Feb 18, 2024
@fkiraly
[ENH] adapter to pyts KNeighborsClassifier (#5939)
b5027a4 
Adapter for `pyts.classification.KNeighborsClassifier`, using the
generic adapter introduced in #5851.
Serves as a test case for classifiers, and possibly fixes
#5914.

Depends on #5851 for the adapter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
interfacing algorithms Interfacing existing algorithms/estimators from third party packages module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fkiraly