Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] [BUG] fix moto breaking change by using different mocking methods depending on version #5858

Merged
merged 1 commit into from Jan 30, 2024
Merged

[MNT] [BUG] fix moto breaking change by using different mocking methods depending on version #5858

merged 1 commit into from Jan 30, 2024

Conversation

yarnabrina
Copy link
Collaborator

Closes #5855

@yarnabrina yarnabrina mentioned this pull request Jan 29, 2024
Closed
fkiraly
fkiraly approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the package and figuring out where mock_s3 went.

Non-blocking question above about how to check.

@yarnabrina yarnabrina mentioned this pull request Jan 30, 2024
Closed
@yarnabrina yarnabrina merged commit 0c134d5 into sktime:main Jan 30, 2024
352 of 358 checks passed
@yarnabrina yarnabrina deleted the handle-moto branch January 30, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] failure of mlflow integration tests due to missing moto.mock_s3 on moto>=5.0.0
2 participants
@yarnabrina @fkiraly