Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 5918 and 5919, fix missing loc/scale in TDistribution methods #5942

Merged
merged 8 commits into from
Feb 20, 2024

Conversation

ivarzap
Copy link
Contributor

@ivarzap ivarzap commented Feb 13, 2024

Reference Issues/PRs

Fixes #5918 and fixes #5919

What does this implement/fix? Explain your changes.

Uses scale/location to compute var, pdf, log_pdf, cdf and ppf from TDistribution

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

fkiraly
fkiraly previously approved these changes Feb 13, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all looks fixed now!

What would be great if you could make the same PR to skpro - we are in the middle of a refactor, but cannot take a dependency before it is released on conda. Until then, code has to be duplicated.

@fkiraly fkiraly changed the title [BUG]-5918 and [BUG]-5919, TDistribution issues [BUG] 5918 and 5919, fix missing loc/scale in TDistribution functions Feb 13, 2024
@fkiraly fkiraly changed the title [BUG] 5918 and 5919, fix missing loc/scale in TDistribution functions [BUG] 5918 and 5919, fix missing loc/scale in TDistribution methods Feb 13, 2024
@fkiraly fkiraly added bugfix Fixes a known bug or removes unintended behavior module:probability&simulation probability distributions and simulators labels Feb 13, 2024
@fkiraly fkiraly merged commit e535a1a into sktime:main Feb 20, 2024
52 checks passed
yarnabrina pushed a commit that referenced this pull request Mar 3, 2024
@ivarzap forgot to add author credits in #5942, fixed.
fnhirwa pushed a commit to fnhirwa/sktime that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TDistribution computes incorrectly variance [BUG] TDistribution pdf does not consider location/scale
2 participants