Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] CI on main fix: add checkout step to detect steps in CI #5945

Merged
merged 1 commit into from Feb 14, 2024
Merged

[MNT] CI on main fix: add checkout step to detect steps in CI #5945

merged 1 commit into from Feb 14, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Feb 14, 2024

This PR attempts the fix proposed by @yarnabrina, adding a checkout action to detect steps, to fix CI failures on main.

Fixes #5940

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution bugfix Fixes a known bug or removes unintended behavior labels Feb 14, 2024
yarnabrina
yarnabrina approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@yarnabrina yarnabrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may merge even without CI to finish I think, because it already passes in CI's from PR.

@fkiraly fkiraly merged commit fdb3754 into main Feb 14, 2024
33 of 34 checks passed
@fkiraly fkiraly deleted the detect-checkout branch February 14, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarnabrina yarnabrina yarnabrina approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one assigned
Labels
bugfix Fixes a known bug or removes unintended behavior maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MNT] CI is failing on main
2 participants
@fkiraly @yarnabrina