New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] refactor Catch22Wrapper
transformer to use pd.Series
type internally
#5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
module:transformations
transformations module: time series transformation, feature extraction, pre-/post-processing
label
Feb 22, 2024
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
February 22, 2024 18:07
FYI @yarnabrina, highlighting this as an example where Many of the "panel" transformers aren't really panel transformers, just series transformers with very similar custom broadcasting logic, as above. Related issue: #5745 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Adding new functionality
module:transformations
transformations module: time series transformation, feature extraction, pre-/post-processing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
Catch22Wrapper
transformer to usepd.Series
type internally, from the oldnested_univ
type.This also means that parallelization is now supported via broadcasting and
set_config
, instead of being fused with the transformer.For the deprecation period, if
n_jobs
is passed, the estimator usesset_config
internally.