Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] refactor Catch22Wrapper transformer to use pd.Series type internally #5983

Merged
merged 17 commits into from Feb 25, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Feb 22, 2024

This refactors the Catch22Wrapper transformer to use pd.Series type internally, from the old nested_univ type.

This also means that parallelization is now supported via broadcasting and set_config, instead of being fused with the transformer.

For the deprecation period, if n_jobs is passed, the estimator uses set_config internally.

@fkiraly fkiraly added the module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing label Feb 22, 2024
@fkiraly fkiraly added the enhancement Adding new functionality label Feb 22, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Feb 24, 2024

FYI @yarnabrina, highlighting this as an example where check_n_jobs is being removed due to removal of redundant broadcasting logic inside a "panel" transformer - related issue: #5990

Many of the "panel" transformers aren't really panel transformers, just series transformers with very similar custom broadcasting logic, as above.

Related issue: #5745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant