Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixed transform method of MSTL transformer #5996

Merged
merged 7 commits into from Feb 25, 2024

Conversation

Abhay-Lejith
Copy link
Contributor

Reference Issues/PRs

This fixes #5995 .

What does this implement/fix? Explain your changes.

The error was due to use of the deprecated iteritems() function in pandas. I have changed it to the equivalent items() function.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • you also get the code badge for fixing the bug
  • can you ensure to add a test? Adding the failing parameter combination to get_test_params should suffice (you can check with check_estimator, it fails before the fix)

@fkiraly fkiraly added module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing bugfix Fixes a known bug or removes unintended behavior labels Feb 24, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Great first contribution, welcome to sktime!

@fkiraly fkiraly merged commit 64e90aa into sktime:main Feb 25, 2024
54 checks passed
@Abhay-Lejith
Copy link
Contributor Author

Abhay-Lejith commented Feb 25, 2024

Thanks!

Great first contribution, welcome to sktime!

Thank you! looking forward to making more valuable contributions.

@Abhay-Lejith Abhay-Lejith deleted the MSTL_transform_fix branch February 25, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] transform method of MSTL transformer does not work.
2 participants