New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Examples for YtoX
transformer
#6028
Conversation
@fkiraly That is an easy fix, if you ask me I'll be happy to check, test, fix and add the examples for this class. |
Would you like to add more examples? Sure, if you would like to, in anothe PR? |
Thanks, I'll do in another PR |
Sure! I recommend then branching off this branch, to avoid merge conflicts. |
This is a continuation of this PR: sktime#6028
Thanks for letting me do the examples. I was really struggling with YtoX and thought it was irrelevant but expermenting with the examples made me rethink of its use. I previously worked on EEG dataset and just realized how easy would have the things been if I used this approach. I have made minor fixes to examples, branching off from this branch, in this PR: #6059 |
Interesting statement - what this makes me think, and imagine reading between the lines, is that the tutorials are not as clear as they could be on building pipelines from the various components. I would be keen to hear your opinions, on where/how you specifically would have expected explanations, or whether there were places where you felt more confused than informed. |
There were actually no example use-cases for It was simple, I was just not looking with the right approach. I just thought why to use a transformer to convert Thanks |
Oh - that seems like an oversight. I would have expected them in tutorial 03b. Perhaps it's time for an update, there are various workshops (in the sktime GitHub organisation, www.github.com/sktime) which might have relevant material, in addition. |
#### Reference Issues/PRs Continuation to this PR: #6028 #### What does this implement/fix? Explain your changes. - In the mentioned PR, examples were added for `YtoX`. I have made minor fixes in import and pipeline initialization. - Added `load_airline` dataset in both examples. - Replaced `ARMIAX` with `Prophet` which made the forecast resutls better for this particular use-case. - Completed the missing lines to make sure examples can be copied and pasted without any error. #### What should a reviewer concentrate their feedback on? I have considered `pydocstyle` documentation for examples and put `# doctest: +SKIP` for soft-dependencies. I hope I don't miss any line.
Adds examples for
YtoX
transformer in its docstring; also improves docstring formatting and clarity.