Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] remove private methods from parameters of ProximityForest, ProximityTree, and ProximityStump #6046

Merged
merged 26 commits into from Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e91b11f
made setup_distance_measure a method function
fnhirwa Mar 2, 2024
1d7bf1c
distance getter functions
fnhirwa Mar 2, 2024
9651690
fix docstyle
fnhirwa Mar 2, 2024
6168fcd
refactor exemplars methods
fnhirwa Mar 2, 2024
fde536f
refactor the find_stump method
fnhirwa Mar 2, 2024
2b0cad2
add my username to contributors
fnhirwa Mar 2, 2024
e434175
refactor the gain function parameter to the classes
fnhirwa Mar 2, 2024
c4d119f
fixed the ProximityStump docstrings and wrong parameter references
fnhirwa Mar 2, 2024
6a35817
Refactored both classes `ProximityForest`, `ProximityTree` and `Proxi…
fnhirwa Mar 2, 2024
5a5a878
Fix the NoneType error from test logs
fnhirwa Mar 3, 2024
86c3042
Wrongly referenced methods as `distance_measures` causing CI tests to…
fnhirwa Mar 4, 2024
aa2c1b4
fixed the tests using check_stimators to ensure they're passing locally
fnhirwa Mar 4, 2024
c634c5d
[MNT] update codecov configuration and badge URL (#6041)
yarnabrina Mar 1, 2024
8f10b1c
Revert "[MNT] update codecov configuration and badge URL" (#6049)
yarnabrina Mar 2, 2024
ff15e79
[ENH] Migrate DL regressors from sktime-dl: CNTC, InceptionTime, MACN…
nilesh05apr Mar 2, 2024
d8d23ee
[DOC] add missing author credits of @ivarzap (#6050)
fkiraly Mar 3, 2024
d0d909c
[DOC] fix various typos (#6043)
fkiraly Mar 3, 2024
bc35421
[DOC] clarification regarding immutability of `self`-params in extens…
fkiraly Mar 3, 2024
27e00e8
[ENH] `neuralforecast` based LSTM model (#6047)
pranavvp16 Mar 4, 2024
68ff731
fix the nan error in distances calculation
fnhirwa Mar 6, 2024
c9b2649
Merge remote-tracking branch 'upstream/main' into private-methods
fnhirwa Mar 6, 2024
657938a
Merge remote-tracking branch 'upstream/main' into private-methods
fnhirwa Mar 11, 2024
6ac52bd
made gini_gain default gain function and added valid distance measure…
fnhirwa Mar 12, 2024
bcfe189
Merge remote-tracking branch 'upstream/main' into private-methods
fnhirwa Mar 13, 2024
d77b417
a slight correction of the function docstrings
fnhirwa Mar 13, 2024
10b9350
Update .all-contributorsrc
fkiraly Mar 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
Expand Up @@ -2626,6 +2626,15 @@
"maintenance",
"bug"
]
},
{
"login": "fnhirwa",
"name": "Felix Hirwa Nshuti",
"avatar_url": "https://avatars.githubusercontent.com/u/67042527?s=64&v=4",
"profile": "https://github.com/fnhirwa",
"contributions": [
"maintenance"
]
}
]
}