Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Added an example to CNNRegressor #4264 #6102

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

meraldoantonio
Copy link
Contributor

@meraldoantonio meraldoantonio commented Mar 10, 2024

Reference Issues/PRs

Adds to #4264

What does this implement/fix? Explain your changes.

Added one usage example to CNNRegressor.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Reviewing the example and my workflow

Did you add any tests for the change?

No

Any other comments?

No

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

@meraldoantonio meraldoantonio changed the title Added an example to CNNRegressor [DOC] Added an example to CNNRegressor #4264 Mar 10, 2024
@meraldoantonio meraldoantonio marked this pull request as ready for review March 10, 2024 09:16
@fkiraly fkiraly added documentation Documentation & tutorials module:regression regression module: time series regression labels Mar 10, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Mar 10, 2024

Nice, thanks!

@meraldoantonio
Copy link
Contributor Author

Hi @fkiraly, thanks for checking the PR!
If everything is OK, could you please give me the permission to merge it?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@meraldoantonio
Copy link
Contributor Author

One required test failed because of invalid keras filepath, and I'm not too sure how to change this path.. Could someone please help me on this?

This is the error:

ValueError: Invalid filepath extension for saving. Please add either a `.keras` extension for the native Keras format (recommended) or a `.h5` extension. Use `tf.saved_model.save()` if you want to export a SavedModel for use with TFLite/TFServing/etc. Received: filepath=/tmp/pytest-of-runner/pytest-0/popen-gw1/test_cnn_model_save_and_load_p0/model/model/keras.

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 13, 2024

That's unrelated, it is coming from tensorflow recent release being incompatible with the adapter, see here #6094 - nothing about your changes.

@fkiraly fkiraly merged commit fae5cbb into sktime:main Mar 13, 2024
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials module:regression regression module: time series regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants