-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] search function for estimator overview not working #6105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
This is great. May be you want to add yourself as a contributor? Just for my curiosity, did you figure out why was it working before v0.20.1? |
I am working on an interactive table that could sort, group, display comprehensive tags info of estimators etc. Related to this issue: #1930 I extracted the info from all_tags and all_estimators to a json file and working on the dynamic table. You could check the progress here. And suggestions on how the info should be displayed is needed. |
Yes, of course! |
Nice! What would be really interesting is to either give the user an option to select the tags they want displayed, and/or to predefine "interesting" tags if estimator types are selected, e.g., forecaster specific tags for forecaster. Not all tags will be interesting to the user, mostly the ones that start with |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
(reopening until we've consolidated the various nice changes in multiple PR or otherwise) |
So it worked before :). I was curious too. When I searched for jquery in tagv0.20 I could not find any text or file except one instance being So the conf.py was changed somehow for jquery to be excluded or perhaps readthedocs/sphinx used to inject jQuery implicitly, but now no longer. edited: the cause pyda_sphinx_theme dropping jquery pydata/pydata-sphinx-theme#1042 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, so I'll just merge it!
…arch (#6147) #### Reference Issues/PRs #6105 #6106 #4905 The additional build on RTD can be found here in case it is not yet rendered on sktime own RTD. https://duydlsktime.readthedocs.io/en/latest/estimator_overview.html #### What does this implement/fix? Explain your changes. <!-- A clear and concise description of what you have implemented. --> An enhancement to estimator overview table. Support filtering by estimator type and displaying tag. #### Does your contribution introduce a new dependency? If yes, which one? It is implemented in vanilla js.
Reference Issues/PRs
Fixes #5495
What does this implement/fix? Explain your changes.
I identified the location of the Js search function. It was written with jQuery which I was not familiar with. I just rewrote it in vanilla Js and the problem was fixed.
This is very basic so it may not but the most right or efficient. I am going to look further into the documentation and implement some other enhancements for the estimator overview in particular and the docs in general. Then I may find out why the jQuery didn't work or draw up some other solutions.