Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix the colalign functionality to ScipyDist class as specified in the docstrings #6110

Merged
merged 2 commits into from Mar 20, 2024

Conversation

fnhirwa
Copy link
Contributor

@fnhirwa fnhirwa commented Mar 11, 2024

This Pull request adds the colalign functionality to the ScipyDist class as specified in the docstring and corrected the formatting of the docstring of the class.

Reference Issues/PRs

FIxes #1942

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fnhirwa fnhirwa marked this pull request as ready for review March 11, 2024 18:35
@fnhirwa fnhirwa changed the title [BUG] - bugfix Adding the colalign functionality to ScipyDist class as specified in the docstrings [BUG] Fix the colalign functionality to ScipyDist class as specified in the docstrings Mar 12, 2024
@fkiraly fkiraly added module:distances&kernels dists_kernels and distances modules: time series distances, kernels, pairwise transforms enhancement Adding new functionality labels Mar 12, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

I almost forgot about this one, good that you unearthed it!

Looks correct, I'll start the tests.

@fkiraly fkiraly merged commit 2d69837 into sktime:main Mar 20, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:distances&kernels dists_kernels and distances modules: time series distances, kernels, pairwise transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix or remove colalign arg in ScipyDist
2 participants