Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] added test params to RNNNetwork on 3429 #6155

Merged
merged 1 commit into from Mar 19, 2024

Conversation

julian-fong
Copy link
Contributor

What does this implement/fix? Explain your changes.

Implemented the standard 'get_test_params' class method with the appropriate docstring and applicable parameters.

Added a couple test params for RNNNetwork contributing towards #3429. One test param that covers the default set and another that covers the 'units' parameter.

One thing I noticed when going through the docstring for the RNNNetwork class is that there seems to be a missing reference [1] inside.

This is my first pull request ever so please leave me some feedback! :)

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I approve if tets run.

@fkiraly fkiraly added module:classification classification module: time series classification module:regression regression module: time series regression enhancement Adding new functionality labels Mar 17, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Mar 19, 2024

Re missing reference, if you can guess what it should be, adding it would be appreciated.

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 19, 2024

This is my first pull request ever so please leave me some feedback!

All nicely done! PR description is clear, contribution is as specified. You're off to a good start!

@fkiraly fkiraly merged commit 476b63b into sktime:main Mar 19, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:classification classification module: time series classification module:regression regression module: time series regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants