Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] corrected Discord channel mention in developer guide #6163

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

shankariraja
Copy link
Contributor

@shankariraja shankariraja commented Mar 18, 2024

Fixes: #6162

Changed the channel reference from #contributors to #intro in the sktime documentation to accurately reflect the Discord server setup. This ensures that new developers receive correct instructions on how to introduce themselves and engage with the community.

@fkiraly fkiraly changed the title Updated Discord channel mention in developer guide [DOC] corrected Discord channel mention in developer guide Mar 18, 2024
@fkiraly fkiraly added the documentation Documentation & tutorials label Mar 18, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Well-spotted, and apologies for the mistake.

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 18, 2024

Question, since this is about new developers specifically, should we direct them to #dev-chat? Perhaps that's the better channel here.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think #dev-chat gives a nicer onboarding experience. #lobby also makes sense though. Up to you - which channel did you find more helpful?

@shankariraja
Copy link
Contributor Author

@fkiraly Thanks for your input! I'll make the change soon.

fkiraly
fkiraly previously approved these changes Mar 18, 2024
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Just to check, did you think that's the better channel to direct new contributors to?
It's a bit hard for me to judge from the "inside" perspective, while you have the new contributor perspective.

@shankariraja
Copy link
Contributor Author

From my perspective as a new contributor, having a separate channel dedicated to contributor introductions, like #intro, could provide a more focused and welcoming environment for newcomers. However, I've gone ahead and made the change to #dev-chat as per your suggestion. We can always revisit this decision later based on community feedback. Thanks for being open to it!

@shankariraja
Copy link
Contributor Author

Thank you for creating the #intro channel! I appreciate your responsiveness. I'll update the documentation soon to reflect this change. Thanks again for your help!

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 18, 2024

Oh, yes, I wanted to respond here, but then got distracted by discord server settings and how to set up introduction tasks with channel introductions.

Yes, it would be great - if you think that's the right idea to try - to point to #intro.

Further, there is another reference on the "get started" page, it's in contributing.rst (the file behind this page: https://www.sktime.net/en/latest/get_involved/contributing.html)

I suppose that should also point to #intro now?

@shankariraja
Copy link
Contributor Author

Thanks for the update! I'll make sure to update the "get started" page in contributing.rst to reflect this change. Appreciate your input and efforts in improving the onboarding experience for new contributors!

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 18, 2024

Well, thank you for flagging up points of improvement, making suggestions on the how, and of course, the actual changes!

@fkiraly fkiraly merged commit cee2d63 into sktime:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Missing #contributors Channel Mentioned in Developer Guide
2 participants