Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add new test parameter sets for TimeSeriesKMeansTslearn #6195

Merged
merged 3 commits into from Mar 23, 2024
Merged

[ENH] add new test parameter sets for TimeSeriesKMeansTslearn #6195

merged 3 commits into from Mar 23, 2024

Conversation

shankariraja
Copy link
Contributor

@shankariraja shankariraja commented Mar 23, 2024 •
edited by yarnabrina

@yarnabrina
Copy link
Collaborator

I edited your description as it doesn't close #3429 for all estimators, hopefully that's okay with you.

yarnabrina
yarnabrina previously approved these changes Mar 23, 2024
View reviewed changes
sktime/clustering/k_means/_k_means_tslearn.py Outdated Show resolved Hide resolved
sktime/clustering/k_means/_k_means_tslearn.py Outdated Show resolved Hide resolved
@shankariraja
Copy link
Contributor Author

I edited your description as it doesn't close #3429 for all estimators, hopefully that's okay with you.

It's completely fine, @yarnabrina!

fkiraly
fkiraly approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like tslearn fixed the issue!

@shankariraja
Copy link
Contributor Author

Nice, looks like tslearn fixed the issue!

Thanks @fkiraly! looking forward to contribute more.

@fkiraly fkiraly merged commit bd28883 into sktime:main Mar 23, 2024
54 checks passed
@fkiraly fkiraly changed the title Add new test parameter sets for TimeSeriesKMeansTslearn [ENH] add new test parameter sets for TimeSeriesKMeansTslearn Mar 23, 2024
@fkiraly fkiraly added module:clustering clustering module: time series clustering enhancement Adding new functionality labels Mar 23, 2024
@shankariraja shankariraja deleted the addparms branch March 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@yarnabrina yarnabrina yarnabrina left review comments

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one assigned
Labels
enhancement Adding new functionality module:clustering clustering module: time series clustering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shankariraja @yarnabrina @fkiraly