[ENH] Added test parameters for the LSTM FCNN network #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlok191
requested review from
achieveordie,
benHeid,
fkiraly and
yarnabrina
as code owners
fkiraly
added
module:classification
|
Thanks! For the tests to run, kindly ensure you adhere to sktime code formatting standards: |
|
Oh I see! Thank you so much for the help @fkiraly. I have set up pre-commit now and verified that my code meets the standards before pushing the final fix commit. Hopefully this one works! 😃 |
fkiraly
requested changes
Apr 11, 2024
|
Got it, just pushed a commit with the desired changes! |
fkiraly
approved these changes
Apr 11, 2024
toandaominh1997
pushed a commit
to toandaominh1997/sktime
that referenced
this pull request
Apr 18, 2024
I have added 2 test parameters for the LSTM-FCNN network returned via the `get_test_params` function. The test parameters aim to explore 2 quite different variations of the model in the hope to capture a broad spectrum of the model's parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Contributes to #3429
Added 2 test parameters for the
LSTMFCNNNetworkas mentioned here: #3429. One of the parameters sets out a simpler version of the model, and the other tests a more sophisticated modelWhat does this implement/fix? Explain your changes.
I have added 2 test parameters for the LSTM-FCNN network returned via the
get_test_paramsfunction. The test parameters aim to explore 2 quite different variations of the model in the hope to capture a broad spectrum of the model's parameters.Does your contribution introduce a new dependency? If yes, which one?
It does not!
What should a reviewer concentrate their feedback on?
I would direct anyone's attention to the added function:
sktime/networks/lstmfcn.py/get_test_paramsstarting from line 128. I can absolutely work on improving the parameters if they are not quite as good, but that is the only major place I have made a change!Did you add any tests for the change?
I have not added any tests for the commits I made
PR checklist
For all contributions
I've added myself to the list of contributors with any new badges I've earned :-)
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.