[MNT] Update dask requirement from <2024.2.2 to <2024.4.2, add new required dataframe extra to pyproject.toml.
#6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarnabrina
requested review from
achieveordie,
benHeid and
fkiraly
as code owners
fkiraly
added
maintenance
fkiraly
changed the title
<2024.2.2 to <2024.4.2, add new required dataframe extra to pyproject.toml.
|
Turns out we had the same idea, see #6255 Your fix does not work because your syntax is not PEP 508 compliant, you need to add extras as a PEP 508 marker. Since you had the idea first, I've changd this PR so it works and credit goes to you, and will close the modified dependabot one. |
fkiraly
approved these changes
Apr 10, 2024
6 tasks
fkiraly
added a commit
that referenced
this pull request
Apr 11, 2024
It seems the fix #6282 caused another issue - I believe the reason is that `dask` removed `pyyaml` as a dependency. Consequently, the `import yaml` statement in the mlflow module now fails, post #6282. Unclear why the tests did not recognize this. The fix should be this: import `yaml` only if `mlflow` is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6280 by updating
daskto the newest version which fixes incompatibility with python 3.11.9