Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix dependent tags of TimeSeriesDBSCAN #6322

Merged
merged 2 commits into from Apr 23, 2024
Merged

[BUG] fix dependent tags of TimeSeriesDBSCAN #6322

merged 2 commits into from Apr 23, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Apr 22, 2024

TimeSeriesDBSCAN does not set its tags correctly if one of the numba based distance in sktime is used. In this case, it cannot support unequal length time series, and the corresponding tag needs to be set.

Similarly, the tags for some of the numba distances were set incorrectly, which is now corrected as well.

@fkiraly fkiraly added module:clustering clustering module: time series clustering bugfix Fixes a known bug or removes unintended behavior labels Apr 22, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Apr 23, 2024

quick merge due to failures on main

@fkiraly fkiraly merged commit c5f425d into main Apr 23, 2024
68 checks passed
@fkiraly fkiraly deleted the fix-dbscan-tags branch April 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:clustering clustering module: time series clustering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant