[ENH] performance optimization for _check_soft_dependencies, speed up test collection time
#6355
+58
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:tests
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the runtime of
_check_soft_dependencies, speeding up test collection time, towards #6344.The speed-up comes from using
importlibfind_specinstead of actually attempting an import and catching the exception.The "suppress std out" argument becomes obsolete, as no output is generated when not importing the module.
This PR also fixes an unreported bug in the
sktimecode base, where the package (PEP 440)scikit-learnwas referred to assklearn.