[BUG] fix test_run_test_for_class logic check if ONLY_CHANGED_MODULES flag is False and all estimator dependencies are present
#6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:tests
yarnabrina
approved these changes
May 3, 2024
|
to be safe, we should probably run a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unreported bug pointed out by @yarnabrina in the test
test_run_test_for_class, in the check for the logic ofrun_test_for_classreturning an attribution of its test yes/no flag to a reason.If
ONLY_CHANGED_MODULESflag isFalseand all estimator dependencies are present, the reason returned should beTrue_run_always, but the test checks incorrectly for another positive reason.This is fixed - a bug with the test, not with
run_test_for_class- as it did not take into account properly the combination ofONLY_CHANGED_MODULES = Falseand all dependencies present, which in our CI occurs only intest_all.