[ENH] allow passing of transformer object to hugging face transformer #6642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spinachboul
requested review from
achieveordie,
benHeid,
fkiraly and
yarnabrina
as code owners
benHeid
reviewed
Jun 21, 2024
| @@ -101,7 +102,8 @@ class HFTransformersForecaster(BaseForecaster): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| model_path: str, | |||
| model_path: str = None, | |||
There was a problem hiding this comment.
I would propose to use in future only model and set a deprecation warning for model_path because in my opinion this additional kwarg is not necessary, since model_path and model has basically the same meaning.
@fkiraly any opinions
There was a problem hiding this comment.
@benHeid
If that is the case, can we import the warnings dependency in the start?
Would it interfere in the checks during build process?
benHeid
requested changes
Jun 21, 2024
| ) | ||
| if self.model is None and self.model_path is not None: | ||
| # Load model and extract config | ||
| config = AutoConfig.from_pretrained(self.model_path) |
There was a problem hiding this comment.
I would propose to move the model loading functionality into a private method to keep the fit method simpler. E.g. into a method _load_model
fkiraly
changed the title
|
@benHeid | @fkiraly | @achieveordie | @yarnabrina
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fkiraly & @benHeid
Invoking model object for the Issue #6561