Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to contributing.md to include directions to installation #695

Merged
merged 3 commits into from Feb 26, 2021

Conversation

kanand77
Copy link
Contributor

Reference Issues/PRs

Making it simpler for new users to directly link to installation steps from the CONTRIBUTING.md file

What does this implement/fix? Explain your changes.

Adding in a few extra lines to the CONTRIBUTING.md documentation to help new users avoid some easy bugs that they may first encounter if they don't have the environment properly set up.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Seeing if the edit is well positioned or should be changed

Any other comments?

None

PR checklist

For all contributions
  • [x ] I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • [ x] I've added unit tests and made sure they pass locally.
    • None needed
For new estimators -- not needed
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@mloning mloning added the documentation Documentation & tutorials label Feb 19, 2021
@mloning
Copy link
Contributor

mloning commented Feb 19, 2021

Thanks @kanand77 - seems like a code quality check didn't pass, let me know if you need help with those.

@afzal442
Copy link
Contributor

afzal442 commented Feb 21, 2021

Thanks @kanand77 for this PR. I also had it in my mind to have such changes. Hoping it gets fixed and merged.

@mloning mloning merged commit fcff3d6 into sktime:master Feb 26, 2021
@mloning
Copy link
Contributor

mloning commented Feb 26, 2021

Nicely done, thanks @kanand77, now merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants