This repository has been archived by the owner on Feb 10, 2024. It is now read-only.
Fixes empty control exception when a document type is not saved after… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding a cell Steps to reproduce exception: - Choose a layout - Add an element - Select any DTGE element - Choose the Cancel button A layout should then contain an empty cell which holds no data due to the document type instance not being saved. When rendering the grid on a page template, the following change is required as the `docTypeAlias` parameter is empty. I'm not sure whether the issue is related to the grid or the DTGE but the change proposed appears to fix the issue.
|
Good find Dan, thanks for reporting this. I need to make some changes to DTGE which will likely happen after CG now, but when I do those updates, I'll try this out aswell. Thanks again Matt |
|
Thanks Matt 👍 |
leekelleher
added a commit
that referenced
this pull request
Oct 22, 2015
Fixes empty control exception when a document type is not saved after…
|
Finally merging the PR in, thanks @danlister - sorry it's taken so long! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… adding a cell
Steps to reproduce exception:
A layout should then contain an empty cell which holds no data due to the document type instance not being saved. When rendering the grid on a page template, the following change is required as the
docTypeAliasparameter is empty.I'm not sure whether the issue is related to the grid or the DTGE but the change proposed appears to fix the issue.