Remove current user from list #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display "no user" label in case there is no one to select DIsplay "you ned admin rihts" on non-admin users
|
Looks great - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #6 and I took the liberty to do some fine-tuning as follow
The "imperonate" button is disabled until you select a user (see image above)
If the list is empty, we display a message "no user to impersonate"
The two latter points are there because we actually always have the dashboard title "User Impersonation" displayed, which means that if the impersonation component itself would not display anything (like it is now), the user sees a title with nothing under it, and I thought this seemed kind of odd. 馃槈
Beware that updates to Danish translation file come from Google translate 馃槄