Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for when attribute using getattr to ignore other report objects. #5

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

tirkarthi
Copy link
Contributor

Fixes #4

I have used getattr but one possible solution would be to just check for TestReport but this can cause issues where other objects that have call but are not subclass of TestReport to fail.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #5 (5edca4d) into master (cdda8d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           61        61           
=========================================
  Hits            61        61           
Impacted Files Coverage Δ
pytest_timer/plugin.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdda8d3...5edca4d. Read the comment docs.

@marcglobality
Copy link

thanks for this, hope it's merged soon

@skudriashev
Copy link
Owner

@marcglobality thanks for fixing this. Going to look into this today.

@skudriashev skudriashev self-requested a review June 1, 2021 18:07
@skudriashev skudriashev merged commit 4479280 into skudriashev:master Jun 2, 2021
@tirkarthi
Copy link
Contributor Author

Thanks @skudriashev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings in test cause AttributeError
3 participants