Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complex internal representation #1128

Merged
merged 2 commits into from Aug 5, 2020
Merged

complex internal representation #1128

merged 2 commits into from Aug 5, 2020

Conversation

s-cork
Copy link
Contributor

@s-cork s-cork commented Jul 13, 2020 •
edited

Currently we use Sk.builtin.float_ to represent complex number real and imag parts

this pr changes the internal representation to javascript numbers.
It simplifies complex.js somewhat as we no longer do this.real.v but just this.real

albertjan
albertjan approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@albertjan albertjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one small question

@s-cork s-cork force-pushed the pr/complexInternal branch 2 times, most recently from 8bac1e2 to be789b2 Compare August 5, 2020 09:30
meredydd
meredydd approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@meredydd meredydd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified and better performance. You're on a roll! LTGM.

@meredydd meredydd merged commit 3d45ca7 into skulpt:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meredydd meredydd meredydd approved these changes

@albertjan albertjan albertjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s-cork @meredydd @albertjan