Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists of Figures and Tables do not appear in Table of Contents #37

Open
mjost5v opened this issue Apr 4, 2020 · 21 comments
Open

Lists of Figures and Tables do not appear in Table of Contents #37

mjost5v opened this issue Apr 4, 2020 · 21 comments

Comments

@mjost5v
Copy link

mjost5v commented Apr 4, 2020

According to my correspondence with the ETD Administrator, the List of Figures and List of Tables should appear as entries in the Table of Contents. Currently, they do not. I've spent many hours trying to get them to render. The only workaround is to manually add them after the fact with the Professional version of Adobe Acrobat.

@skulumani
Copy link
Owner

skulumani commented Apr 4, 2020 via email

@mjost5v
Copy link
Author

mjost5v commented Apr 4, 2020 via email

@skulumani
Copy link
Owner

Thanks for the details. There's been some changes to the class since 2018. Let me review and look into it.

@skulumani
Copy link
Owner

This commit

1f65226

Has functional figures and tables in the TOC.

The subsequent changes have broken the TOC.

@skulumani
Copy link
Owner

@mjost5v Thanks for bringing this up. I'm going to contact ETD directly and figure out the changes required between 2018 and 2020.

Then I'll update this package to be current.

@themikesmith
Copy link
Contributor

themikesmith commented Apr 4, 2020 via email

@mjost5v
Copy link
Author

mjost5v commented Apr 4, 2020 via email

@themikesmith
Copy link
Contributor

themikesmith commented Apr 4, 2020 via email

@skulumani
Copy link
Owner

My guess is that each of you are sending your own dissertation to check? She's obviously not consistent in her review of anyone's dissertation.

The whole goal of this template is to allow for all of you to have a simple way to draft a thesis that conforms to the guidelines. It's now clear there are no guidelines.

I also sent an email to Valerie at ETD to verify the required format of the sample thesis template.

Hopefully she'll reply and I'll update the thesis, building off the work of @themikesmith, @mjost5v

For now I've reverted to the 2018 version on master.

I'm pretty sure the changes are just minor? Some line spacing, names, etc?

@mjost5v
Copy link
Author

mjost5v commented Apr 4, 2020 via email

@skulumani
Copy link
Owner

@mjost5v All of those things are configurable.

You can utilize the glossaries or acronym package

i.e. \hidelistofabbreviations or \hideglossarieslistofabbreviations

@mjost5v
Copy link
Author

mjost5v commented Apr 4, 2020 via email

@themikesmith
Copy link
Contributor

themikesmith commented Apr 4, 2020 via email

@skulumani
Copy link
Owner

@mjost5v Thanks for the PR. I'll add it as well.

I'm not super clear on the changes @themikesmith made but the current master has the version from 2018 that is fully functional and was once approved.

My suggestion is to not worry about the formatting right now (unless it's due immediately or something) and just work on content.

I'll fix the template once I hear back from Valerie. I'm not sure why this is so complicated for GWU/SEAS

@skulumani
Copy link
Owner

@themikesmith What was the reason for the tocloft package again?

@themikesmith
Copy link
Contributor

Unfortunately our dissertations are due April 15.

@skulumani I added the tocloft package because apparently the TOC needs to be indented? That seemed like the most elegant way to do it while also allowing for random other things like controlling for line spacing, etc., but I'm not married to it. @mjost5v See above for a (very hacky) fix given the deadline.

In terms of other changes, I'm sorry I don't recall exactly what they were - I put this out of mind a month ago when Valerie approved the template updates. Not an exclusive list, but beyond the above, I definitely futzed with the formatting and line spacing and numerous other minutiae.

I can help you update this after April 15.

@themikesmith
Copy link
Contributor

FYI @mjost5v : tocloft is also likely overriding the other \listofX functions, so the hack given the deadline for those will be similar

@skulumani
Copy link
Owner

No problem @themikesmith. I appreciate the help. Hopefully you and @mjost5v can get something helpful in order to submit on time.

I'll work to ensure it's updated.

For anyone else, make sure you utilize this class file from source rather than through CTAN/Overleaf as though are now probably not valid anymore.

@themikesmith
Copy link
Contributor

themikesmith commented Apr 4, 2020

I just updated the template on overleaf with directions on how to fix if they encounter this temporary problem given the 4/15 deadline @skulumani I will reply once the template is up

@mjost5v
Copy link
Author

mjost5v commented Apr 4, 2020 via email

@themikesmith
Copy link
Contributor

@mjost5v Congratulations!! I'm a week or so behind you :) I'm sorry you had to deal with what seems like fickle guidelines. Best of luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants