-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists of Figures and Tables do not appear in Table of Contents #37
Comments
No that's not correct way to do it.
Can you provide a minimum working example?
…On Sat, Apr 4, 2020 at 2:35 PM Michael Trotter ***@***.***> wrote:
According to my correspondence with the ETD Administrator, the List of
Figures and List of Tables should appear as entries in the Table of
Contents. Currently, they do not. I've spent many hours trying to get them
to render. The only workaround is to manually add them after the fact with
the Professional version of Adobe Acrobat.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIFUZTVTLVWQESYR7TAID3RK54WHANCNFSM4L63N44A>
.
|
I made no changes besides the spacing for which I put in a PR and included
some packages for my submission. Those packages would not cause this issue.
Your example also does not include the lists of figures and tables:
https://github.com/skulumani/thesis-gwu/blob/master/thesis_gwu_master.pdf
On Sat, Apr 4, 2020, 2:39 PM Shankar Kulumani <notifications@github.com>
wrote:
… No that's not correct way to do it.
The Lists of Figures and Tables were already part of the table of contents.
What changes were made to break that functionality?
On Sat, Apr 4, 2020 at 2:35 PM Michael Trotter ***@***.***>
wrote:
> According to my correspondence with the ETD Administrator, the List of
> Figures and List of Tables should appear as entries in the Table of
> Contents. Currently, they do not. I've spent many hours trying to get
them
> to render. The only workaround is to manually add them after the fact
with
> the Professional version of Adobe Acrobat.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#37>, or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABIFUZTVTLVWQESYR7TAID3RK54WHANCNFSM4L63N44A
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRCH24PPOQ4RFJ3LI5ACDRK55EPANCNFSM4L63N44A>
.
|
Thanks for the details. There's been some changes to the class since 2018. Let me review and look into it. |
This commit Has functional figures and tables in the TOC. The subsequent changes have broken the TOC. |
@mjost5v Thanks for bringing this up. I'm going to contact ETD directly and figure out the changes required between 2018 and 2020. Then I'll update this package to be current. |
Hi all, I made the recent updates. Please find below verification from ETD
that the attached PDF conforms as of 2020.
---------- Forwarded message ---------
From: etds etds ***@***.***>
Date: Wed, Mar 4, 2020 at 1:23 PM
Subject: Re: One more correction
To: Michael Smith ***@***.***>
Michael,
This last one looks good to me.
Valerie
@mjost5v <https://github.com/mjost5v> were you dealing with Valerie at ETD?
Did she make a mistake when she signed off on my template changes?
Best,
Mike
…On Sat, Apr 4, 2020 at 3:29 PM Shankar Kulumani ***@***.***> wrote:
@mjost5v <https://github.com/mjost5v> Thanks for bringing this up. I'm
going to contact ETD directly and figure out the changes required between
2018 and 2020.
Then I'll update this package to be current.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM2N7BM7DUTZT7OW4QEDY3RK6DAJANCNFSM4L63N44A>
.
|
Yes, I was dealing with Valerie. She was very insistent about the lists
being in the table of contents.
…On Sat, Apr 4, 2020, 4:27 PM Michael Smith ***@***.***> wrote:
Hi all, I made the recent updates. Please find below verification from ETD
that the attached PDF conforms as of 2020.
> ---------- Forwarded message ---------
> From: etds etds ***@***.***>
> Date: Wed, Mar 4, 2020 at 1:23 PM
> Subject: Re: One more correction
> To: Michael Smith ***@***.***>
>
>
> Michael,
>
> This last one looks good to me.
>
> Valerie
>
@mjost5v <https://github.com/mjost5v> were you dealing with Valerie at
ETD?
Did she make a mistake when she signed off on my template changes?
Best,
Mike
On Sat, Apr 4, 2020 at 3:29 PM Shankar Kulumani ***@***.***>
wrote:
> @mjost5v <https://github.com/mjost5v> Thanks for bringing this up. I'm
> going to contact ETD directly and figure out the changes required between
> 2018 and 2020.
>
> Then I'll update this package to be current.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#37 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ABM2N7BM7DUTZT7OW4QEDY3RK6DAJANCNFSM4L63N44A
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRCH55TV2BTTCTR72K7TDRK6JZPANCNFSM4L63N44A>
.
|
That's incredibly frustrating. I specifically asked Valerie over a month
ago to verify my changes to the template before I contacted @skulumani -
Either she made a mistake on yours, or on my template, or she changed her
mind. (I hope it's not the third one.)
I just contacted Valerie as well. This is ridiculous. It's April 4th and
the deadline is the 15th.
For what it's worth @mjost5v my changes to the TOC involve the tocloft
package - I used this because (among other things) the TOC now needs to be
indented?
On Sat, Apr 4, 2020 at 4:29 PM Michael Trotter <notifications@github.com>
wrote:
… Yes, I was dealing with Valerie. She was very insistent about the lists
being in the table of contents.
On Sat, Apr 4, 2020, 4:27 PM Michael Smith ***@***.***>
wrote:
> Hi all, I made the recent updates. Please find below verification from
ETD
> that the attached PDF conforms as of 2020.
>
> > ---------- Forwarded message ---------
> > From: etds etds ***@***.***>
> > Date: Wed, Mar 4, 2020 at 1:23 PM
> > Subject: Re: One more correction
> > To: Michael Smith ***@***.***>
> >
> >
> > Michael,
> >
> > This last one looks good to me.
> >
> > Valerie
> >
> @mjost5v <https://github.com/mjost5v> were you dealing with Valerie at
> ETD?
> Did she make a mistake when she signed off on my template changes?
> Best,
> Mike
>
> On Sat, Apr 4, 2020 at 3:29 PM Shankar Kulumani <
***@***.***>
> wrote:
>
> > @mjost5v <https://github.com/mjost5v> Thanks for bringing this up. I'm
> > going to contact ETD directly and figure out the changes required
between
> > 2018 and 2020.
> >
> > Then I'll update this package to be current.
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <
> #37 (comment)
>,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ABM2N7BM7DUTZT7OW4QEDY3RK6DAJANCNFSM4L63N44A
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#37 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAFRCH55TV2BTTCTR72K7TDRK6JZPANCNFSM4L63N44A
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM2N7EWF6T6CDG76JKC6U3RK6KD7ANCNFSM4L63N44A>
.
|
My guess is that each of you are sending your own dissertation to check? She's obviously not consistent in her review of anyone's dissertation. The whole goal of this template is to allow for all of you to have a simple way to draft a thesis that conforms to the guidelines. It's now clear there are no guidelines. I also sent an email to Valerie at ETD to verify the required format of the sample thesis template. Hopefully she'll reply and I'll update the thesis, building off the work of @themikesmith, @mjost5v For now I've reverted to the 2018 version on master. I'm pretty sure the changes are just minor? Some line spacing, names, etc? |
To be fair, the example from before had list of abbreviations listed 2x:
https://github.com/skulumani/thesis-gwu/blob/643837c78e84b0e881a769861776e89674c9e2b7/thesis-sample.pdf
…On 4/4/2020 4:50 PM, Michael Smith wrote:
That's incredibly frustrating. I specifically asked Valerie over a month
ago to verify my changes to the template before I contacted @skulumani -
Either she made a mistake on yours, or on my template, or she changed her
mind. (I hope it's not the third one.)
I just contacted Valerie as well. This is ridiculous. It's April 4th and
the deadline is the 15th.
For what it's worth @mjost5v my changes to the TOC involve the tocloft
package - I used this because (among other things) the TOC now needs to be
indented?
On Sat, Apr 4, 2020 at 4:29 PM Michael Trotter ***@***.***>
wrote:
> Yes, I was dealing with Valerie. She was very insistent about the lists
> being in the table of contents.
>
> On Sat, Apr 4, 2020, 4:27 PM Michael Smith ***@***.***>
> wrote:
>
> > Hi all, I made the recent updates. Please find below verification from
> ETD
> > that the attached PDF conforms as of 2020.
> >
> > > ---------- Forwarded message ---------
> > > From: etds etds ***@***.***>
> > > Date: Wed, Mar 4, 2020 at 1:23 PM
> > > Subject: Re: One more correction
> > > To: Michael Smith ***@***.***>
> > >
> > >
> > > Michael,
> > >
> > > This last one looks good to me.
> > >
> > > Valerie
> > >
> > @mjost5v <https://github.com/mjost5v> were you dealing with Valerie at
> > ETD?
> > Did she make a mistake when she signed off on my template changes?
> > Best,
> > Mike
> >
> > On Sat, Apr 4, 2020 at 3:29 PM Shankar Kulumani <
> ***@***.***>
> > wrote:
> >
> > > @mjost5v <https://github.com/mjost5v> Thanks for bringing this
up. I'm
> > > going to contact ETD directly and figure out the changes required
> between
> > > 2018 and 2020.
> > >
> > > Then I'll update this package to be current.
> > >
> > > —
> > > You are receiving this because you are subscribed to this thread.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
#37 (comment)
> >,
> > > or unsubscribe
> > > <
> >
>
https://github.com/notifications/unsubscribe-auth/ABM2N7BM7DUTZT7OW4QEDY3RK6DAJANCNFSM4L63N44A
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
>
#37 (comment)>,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAFRCH55TV2BTTCTR72K7TDRK6JZPANCNFSM4L63N44A
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
>
<#37 (comment)>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ABM2N7EWF6T6CDG76JKC6U3RK6KD7ANCNFSM4L63N44A>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRCHZZS3Y6WKHEWHBQWPTRK6MSPANCNFSM4L63N44A>.
|
@mjost5v All of those things are configurable. You can utilize the i.e. |
My PR is a trivial line spacing change from 3 lines to 1 between the
author and title for that section.
I did my best to get the lists into the TOC. After many hours of various
LaTeX hacks, I was unable to do so and had to manually edit the
generated PDF in Adobe Acrobat Professional and add the lines and
bookmarks. I was fortunate to have Adobe CC already on my machine. SEAS
students just got access to it this semester.
…On 4/4/2020 4:54 PM, Shankar Kulumani wrote:
My guess is that each of you are sending your own dissertation to
check? She's obviously not consistent in her review of anyone's
dissertation.
The whole goal of this template is to allow for all of you to have a
simple way to draft a thesis that conforms to the guidelines. It's now
clear there are no guidelines.
I also sent an email to Valerie at ETD to verify the required format
of the sample thesis template.
Hopefully she'll reply and I'll update the thesis, building off the
work of @themikesmith <https://github.com/themikesmith>, @mjost5v
<https://github.com/mjost5v>
For now I've reverted to the 2018 version on master.
I'm pretty sure the changes are just minor? Some line spacing, names, etc?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRCH4RQVMFZRL2VTFM2ADRK6M67ANCNFSM4L63N44A>.
|
@mjost5v <https://github.com/mjost5v> , to fix your code and get them to
show up, the tocloft package is redefining the listoffigures commands
later, so....
Insert this in the class file replacing the calls to \listoffigures and
\listoftables at the bottom, in the group starting around line 1430 (there
is likely a more elegant solution here but given we have a very short time
to submit ...)
% Insert the list of figures.
\newcommand{\mylistoffigures}{
\listoffigures
\phantomsection\addcontentsline{toc}{chapter}{List of Figures}
}
\if@gwu@listoffigures\mylistoffigures\fi %
% Insert the list of tables.
\newcommand{\mylistoftables}{
\listoftables
\phantomsection\addcontentsline{toc}{chapter}{List of Tables}
}
\if@gwu@listoftables\mylistoftables\fi %
On Sat, Apr 4, 2020 at 5:01 PM Michael Trotter <notifications@github.com>
wrote:
… My PR is a trivial line spacing change from 3 lines to 1 between the
author and title for that section.
I did my best to get the lists into the TOC. After many hours of various
LaTeX hacks, I was unable to do so and had to manually edit the
generated PDF in Adobe Acrobat Professional and add the lines and
bookmarks. I was fortunate to have Adobe CC already on my machine. SEAS
students just got access to it this semester.
On 4/4/2020 4:54 PM, Shankar Kulumani wrote:
>
> My guess is that each of you are sending your own dissertation to
> check? She's obviously not consistent in her review of anyone's
> dissertation.
>
> The whole goal of this template is to allow for all of you to have a
> simple way to draft a thesis that conforms to the guidelines. It's now
> clear there are no guidelines.
>
> I also sent an email to Valerie at ETD to verify the required format
> of the sample thesis template.
>
> Hopefully she'll reply and I'll update the thesis, building off the
> work of @themikesmith <https://github.com/themikesmith>, @mjost5v
> <https://github.com/mjost5v>
>
> For now I've reverted to the 2018 version on master.
>
> I'm pretty sure the changes are just minor? Some line spacing, names,
etc?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#37 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAFRCH4RQVMFZRL2VTFM2ADRK6M67ANCNFSM4L63N44A
>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM2N7EKJ5GWLJE3SPETZWTRK6NY5ANCNFSM4L63N44A>
.
|
@mjost5v Thanks for the PR. I'll add it as well. I'm not super clear on the changes @themikesmith made but the current master has the version from 2018 that is fully functional and was once approved. My suggestion is to not worry about the formatting right now (unless it's due immediately or something) and just work on content. I'll fix the template once I hear back from Valerie. I'm not sure why this is so complicated for GWU/SEAS |
@themikesmith What was the reason for the |
Unfortunately our dissertations are due April 15. @skulumani I added the tocloft package because apparently the TOC needs to be indented? That seemed like the most elegant way to do it while also allowing for random other things like controlling for line spacing, etc., but I'm not married to it. @mjost5v See above for a (very hacky) fix given the deadline. In terms of other changes, I'm sorry I don't recall exactly what they were - I put this out of mind a month ago when Valerie approved the template updates. Not an exclusive list, but beyond the above, I definitely futzed with the formatting and line spacing and numerous other minutiae. I can help you update this after April 15. |
FYI @mjost5v : tocloft is also likely overriding the other |
No problem @themikesmith. I appreciate the help. Hopefully you and @mjost5v can get something helpful in order to submit on time. I'll work to ensure it's updated. For anyone else, make sure you utilize this class file from source rather than through CTAN/Overleaf as though are now probably not valid anymore. |
I just updated the template on overleaf with directions on how to fix if they encounter this temporary problem given the 4/15 deadline @skulumani I will reply once the template is up |
@skulumani and @themikesmith, I manually edited my output in Adobe
Acrobat Professional to get the thesis updated and approved for
publication yesterday.
…On 4/4/2020 5:16 PM, Michael Smith wrote:
I just updated the template on overleaf with directions on how to fix
if they encounter this temporary problem given the 4/15 deadline
@skulumani <https://github.com/skulumani>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFRCH3SCOSBVMWU2PZQTMLRK6PSVANCNFSM4L63N44A>.
|
@mjost5v Congratulations!! I'm a week or so behind you :) I'm sorry you had to deal with what seems like fickle guidelines. Best of luck. |
According to my correspondence with the ETD Administrator, the List of Figures and List of Tables should appear as entries in the Table of Contents. Currently, they do not. I've spent many hours trying to get them to render. The only workaround is to manually add them after the fact with the Professional version of Adobe Acrobat.
The text was updated successfully, but these errors were encountered: