-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring codebase #120
Refactoring codebase #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the Userflow in the software and all features are working as before. The structure is good and makes the code much more readable. The Design is not yet implemented as it was before. I would like to apply the Style and see if it looks the same before we merge this branch into the master.
}; | ||
|
||
ImGuiInstance window{1280, 760, | ||
ImGuiInstance window{1920, 1080, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this was set to 1280, 760 is because then it will not be to big for little screens. Otherwise the resizing does not work right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Style can be set the same way as before and the software still works.
Took the branch
feature-generate-training-data
which is right before the branch88-enhancement-organisation-and-style
containing the current style.handler.hpp
,style.hpp
,handler.cpp
andstyle.cpp
filesmain.cpp
mostlyThe codebase has been simplified and is at a good readability and maintainability level without any source file inclusion, redundant
.cpp
/.hpp
files or complicated code.main.cpp
has now less than half of code lines compared to its initial version (from 671 to 341).I think this version can be considered as an appropriate base to continue from and add recent features to.
Changes in the commit step-2-changes:
ImGui::BeginChild
s for spacific parts of the programChanges in the commit step-3-changes
handler.hpp
,handler.cpp
,style.hpp
, andstyle.cpp
filesImGui::BeginChild
s and removed redundant onesimagesHeader.hpp
containing the logo in hex datastb_image.h
and loaded the logo image using proper codeChanges in the commit step-4-changes
imagesHeader.hpp
to contain all images yet with less code lines (11,857 to 9844)style.cpp
Changes in the commit step-5-changes
header.hpp
leading to considerable progress in simplicity and readability especially for functionsReset
andVersion