Removed shell-quote-argument for Windows native Emacs to load jar fil…

[abcdec]

…e properly.

shell-quote-argument is preventing native windows Emacs to find jar file. Since start-process is used, it would not need shell quote - should work in Linux as well, but not tested, please test before pull commit.

The original issue was that I was getting

error in process sentinel: if: PLANTUML Preview failed: exited abnormally with code 1
error in process sentinel: PLANTUML Preview failed: exited abnormally with code 1

In *Messages* and
Command is java -jar "c:/Users/tm/AppData/Roaming/.emacs.d/elisp/plantuml.jar"
In *PlantUML Messages*

cygwin Emacs will need another #40 call-process patch to work properly in my environment. Also maybe which version of Java install might make things different.

[skuro]

Testing these changes it appears that nothing break on OS X as well as on native Windows emacs. Truth to be told, I could not reproduce your issue neither: up to 68e5e52 it seems to me that native Windows emacs just works.

Also, another question: you say shell-quote-argument breaks in your setup, but that is actually still used in your PR to load the highlighter keywords.

Given the results of my testing it seems like this PR is actually not needed, but maybe you can provide a way to reproduce the issue you are trying to solve?

Thanks

[iquiw]

shell-quote-argument (with start-process) causes problem even on Unix when the path contains space.

[skuro]

@iquiw interesting, that's one of those cases that shell-quote-argument should be designed to manage, isn't it? Anyway, you are absolutely right, I'll merge the PR asap.

[iquiw]

@skuro I think shell-quote-argument is designed to be used with functions that execute process via shell, such as start-process-shell-command, shell-command, etc.
(So my comment #14 (comment) might be misleading)
Since start-process does not use shell, it does not require shell-quote-argument.

P.S. I am using plantuml-mode a lot, very useful. Thank you, @skuro and @abcdec.

[skuro]

@iquiw I see, I'm still a white belt in emacsland, that's something new I'm learning today :-)
Besides, happy to hear plantuml-mode has been useful!