Add Windows support for GitHub Actions #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not use the functionality provided by FindBISON e.g. BISON_TARGET and so on. All we need below is BISON_EXECUTABLE. Thus, I replaced find_package by find_program and set BISON_EXECUTABLE explicitly. This is also fixes searching executables on Windows systems.
skvadrik
requested changes
Oct 2, 2020
|
By the way, it's the first time I use GitHub review tool, it seems a recent addition. Not bad! |
skvadrik
approved these changes
Oct 2, 2020
|
Merged, thank you! |
|
You're welcome :) |
sergeyklay
added a commit
to sergeyklay/re2c
that referenced
this pull request
Oct 2, 2020
After discussion in skvadrik#311 (comment), I decided to double-check this approach again and made sure that it actually works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds Windows with Visual Studio 16 2019 to the build matrix on GitHub Action. There still a lot of work, e.g. provide ability to run tests, compiler flags definition and so on. But right now it works. I'll try to improve Windows builds a bit later.