Revert breaking change, expose dictionary via internal interface. Bre…

…aking change will be postponed until v4.
skwasjer · Jul 24, 2019 · 8593bae · 8593bae
1 parent 5364406
commit 8593bae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/IbanNet/IbanValidator.cs b/src/IbanNet/IbanValidator.cs
@@ -58,7 +58,13 @@ public IbanValidator(Lazy<IReadOnlyCollection<CountryInfo>> registry)
 		/// <summary>
 		/// Gets the supported countries.
 		/// </summary>
-		public IReadOnlyDictionary<string, CountryInfo> SupportedCountries
+		// TODO: v4, change to dictionary for faster lookup.
+		public IEnumerable<CountryInfo> SupportedCountries => ((ICountryValidationSupport)this).SupportedCountries.Values;
+
+		/// <summary>
+		/// Gets the supported countries.
+		/// </summary>
+		IReadOnlyDictionary<string, CountryInfo> ICountryValidationSupport.SupportedCountries
 		{
 			get
 			{

diff --git a/test/IbanNet.Tests/IbanValidatorTests.cs b/test/IbanNet.Tests/IbanValidatorTests.cs
@@ -181,10 +181,18 @@ public void When_validating_good_iban_should_validate(string countryCode, string
 			actual.Should().BeEquivalentTo(expectedResult);
 		}
 
+		[Test]
+		public void When_getting_supported_countries_should_match_default_registry()
+		{
+			_validator.SupportedCountries
+				.Should()
+				.BeEquivalentTo(new IbanRegistry());
+		}
+
 		[Test]
 		public void When_casting_readonly_countries_dictionary_should_not_be_able_to_add()
 		{
-			var countries = (IDictionary<string, CountryInfo>)_validator.SupportedCountries;
+			var countries = (IDictionary<string, CountryInfo>)((ICountryValidationSupport)_validator).SupportedCountries;
 
 			// Act
 			Action act = () => countries.Add("key", new CountryInfo());