Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules downloaded before installation plan is defined #71

Closed
p7k opened this issue Apr 5, 2012 · 5 comments
Closed

submodules downloaded before installation plan is defined #71

p7k opened this issue Apr 5, 2012 · 5 comments
Assignees

Comments

@p7k
Copy link
Contributor

p7k commented Apr 5, 2012

without looking too much into the rakefile and the logic.
is it absolutely necessary to pull in all the requirements first and later ask whether to install/use yadr aspects [vim, git, etc.]?

@skwp
Copy link
Owner

skwp commented Apr 5, 2012

well, the core of yadr is its vim plugins. I didn't write the installer but I kind of think not installing the vim part is kind of silly, so maybe we should even take that out. so not sure what to do on that front. the idea was to be opinionated and provide a cohesive toolset. I can only think maybe some people may not want to switch shells, but I think everyone should be using the vim stuff

@p7k
Copy link
Contributor Author

p7k commented Apr 5, 2012

refactor to pull externals per selected facet after asking for user input. i appreciate the faceted style. don't force anything.

@skwp
Copy link
Owner

skwp commented Apr 5, 2012

yeah that's cool but like i said the externals are only vim related. if you don't want the vim stuff, don't use this project :)

@skwp
Copy link
Owner

skwp commented Apr 5, 2012

but i would appreciate any and all pull requests that improve on the installer. it's not really my baby to begin with (it was implemented by @kylewest), but I guess I should really sit down and review it again

@kylewest
Copy link
Collaborator

kylewest commented Apr 5, 2012

this makes sense, but I'm not sure it's worthwhile. I could wait to do git submodule update --init until after you say you want to install vim, but that may backfire if a submodule is ever used for something else. I agree with @skyp, I'm not sure anyone would use the project without using the vim facet of it.

@ghost ghost assigned kylewest Apr 5, 2012
@skwp skwp closed this as completed Sep 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants